On 10/20/21 12:13 AM, Christoph Hellwig wrote: > On Tue, Oct 19, 2021 at 10:24:14PM +0100, Pavel Begunkov wrote: >> Inline BIO_NO_PAGE_REF check of bio_release_pages() to avoid function >> call. > > Fine with me, but it seems like we're really getting into benchmarketing > at some point.. I just want to be very clear that neither mine nor Pavel's work is trying to get into benchmarketing. There are very tangible performance benefits, and they are backed up by code analysis and testing. That said, the point is of course not to make this any harder to follow or maintain, but we are doing suboptimal things in various places and those should get cleaned up, particularly when they impact performance. Are some a big eager? Perhaps, but let's not that that cloud the perception of the effort as a whole. The fact that 5.15-rc6 will do ~5.5M/core and post these optimizations we'll be at 9M/core is a solid 60%+ improvement. That's not benchmarketing, that's just making the stack more efficient. -- Jens Axboe
