Re: [PATCH 04/16] block: don't bloat enter_queue with percpu_ref

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/21 07:12, Christoph Hellwig wrote:
On Tue, Oct 19, 2021 at 10:24:13PM +0100, Pavel Begunkov wrote:
percpu_ref_put() are inlined for performance and bloat the binary, we
don't care about the fail case of blk_try_enter_queue(), so we can
replace it with a call to blk_queue_exit().

Thanks for going through the series!

Does this make a difference for you?

It did with a different compiler with extra patches and a different
base, but checking with for-5.16/block the binary size stays the same.


That being said using the proper helpers always seems like a good idea,
so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>


--
Pavel Begunkov



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux