On Tue, Oct 19, 2021 at 10:24:12PM +0100, Pavel Begunkov wrote: > First, get rid of an extra branch and chain error checks. Also reshuffle > it with bio_advance(), so it goes closer to the final check, with that > the compiler loads rq->rq_flags only once, and also doesn't reload > bio->bi_iter.bi_size if bio_advance() didn't actually advanced the iter. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> We should also probably look into killing the whole strange RQF_QUIET to BIO_QUIET some day.
