On 10/19/21 12:42 PM, Keith Busch wrote: > On Tue, Oct 19, 2021 at 09:32:57AM -0600, Jens Axboe wrote: >> There's a hole here we can use, and it's faster to set this earlier > > <snip> > >> @@ -148,6 +148,7 @@ struct blk_mq_alloc_data { >> blk_mq_req_flags_t flags; >> unsigned int shallow_depth; >> unsigned int cmd_flags; >> + unsigned int rq_flags; >> >> /* allocate multiple requests/tags in one go */ >> unsigned int nr_tags; > > The patch looks good, but the new field doesn't appear to occupy a hole. Yes, not sure how I missed the first flags. I'll cut that from the commit message. -- Jens Axboe