Re: [PATCH] blk-mq: don't handle non-flush requests in blk_insert_flush

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/19/21 6:25 AM, Christoph Hellwig wrote:
> Return to the normal blk_mq_submit_bio flow if the bio did not end up
> actually being a flush because the device didn't support it.  Note that
> this is basically impossible to hit without special instrumentation given
> that submit_bio_checks already clears these flags usually, so we'd need a
> tight race to actually hit this code path.
> 
> With this the call to blk_mq_run_hw_queue for the flush requests can be
> removed given that the actual flush requests are always issued via the
> requeue workqueue which runs the queue unconditionally.

This looks great, thanks.

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux