On 10/19/21 1:44 AM, Ming Lei wrote: > On Mon, Oct 18, 2021 at 05:05:50PM +0200, Christoph Hellwig wrote: >> On Mon, Oct 18, 2021 at 04:19:20PM +0200, Lennart Poettering wrote: >>> A brief answer like "yes, please, enable by default" would already >>> make me happy. >> >> I thikn enabling it by default is a good idea. The only good use >> case I can think of for using buffered I/O is when the image has >> a smaller block size than supported on the host file. > > Maybe we can enable it at default in kernel side, then fackback to > buffered IO if DIO is failed. Yes I think that's sane, pure DIO probably isn't a great idea by default. But if we have a sane fallback, then I do think it'd be the best way to run it. -- Jens Axboe