Re: [PATCH blktests] tests/srp: fix module loading issue during srp tests

[Yi Zhang <yi.zhang@xxxxxxxxxx>]

On Fri, Oct 15, 2021 at 11:30 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> On 10/14/21 02:04, Yi Zhang wrote:
> > diff --git a/tests/srp/rc b/tests/srp/rc
> > index 586f007..f89948b 100755
> > --- a/tests/srp/rc
> > +++ b/tests/srp/rc
> > @@ -494,6 +494,7 @@ start_lio_srpt() {
> >       if modinfo ib_srpt | grep -q '^parm:[[:blank:]]*rdma_cm_port:'; then
> >               opts+=("rdma_cm_port=${srp_rdma_cm_port}")
> >       fi
> > +     unload_module ib_srpt && \
> >       insmod "/lib/modules/$(uname -r)/kernel/drivers/infiniband/ulp/srpt/ib_srpt."* "${opts[@]}" || return $?
>
> A nit: the backslash after && can be removed.
>

Thanks Bart, I've sent V2 to fix it.

> Otherwise this patch looks fine to me.
>
> Thanks,
>
> Bart.
>


-- 
Best Regards,
  Yi Zhang