On 9/29/21 1:12 AM, Christoph Hellwig wrote: > Ming reported that for SCSI we have a lifetime problem now that > the BDI moved from the request_queue to the disk as del_gendisk > doesn't finish all outstanding file system I/O. It turns out > this actually is an older problem, although the case where it could > be hit before was very unusual (unbinding of a SCSI upper driver > while the scsi_device stays around). This series fixes this by > draining all I/O in del_gendisk. > > Changes since v2: > - move the call to submit_bio_checks into freeze protection > > Changes since v1: > - fix a commit log typo > - keep the existing nowait vs queue dying semantics in bio_queue_enter > - actually keep q_usage_counter in atomic mode after del_gendisk Looks like there's no other way than going down this path, even though it's not the most exciting right now... I have applied this one for 5.15. -- Jens Axboe