Re: [PATCH 2/7] sd: implement ->get_unique_id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Hannes Reinecke <hare@xxxxxxx>
Subject: Re: [PATCH 2/7] sd: implement ->get_unique_id
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 14 Oct 2021 10:03:32 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Chuck Lever <chuck.lever@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx
In-reply-to: <20211014080134.GA28835@lst.de>
References: <20211012120445.861860-1-hch@lst.de> <20211012120445.861860-3-hch@lst.de> <0a7d87ef-fff2-6a63-8edd-604ad8868dbd@suse.de> <20211014080134.GA28835@lst.de>
User-agent: Mutt/1.5.17 (2007-11-01)

On Thu, Oct 14, 2021 at 10:01:34AM +0200, Christoph Hellwig wrote:
> On Thu, Oct 14, 2021 at 09:30:51AM +0200, Hannes Reinecke wrote:
> > What's wrong with scsi_vpd_lun_id() ?
> 
> It doesn't allow the caller to pick a specific ID type.

... and of course that it returns an ASCSII string instead of the binary
ID.

References:
- remove QUEUE_FLAG_SCSI_PASSTHROUGH
  - From: Christoph Hellwig
- [PATCH 2/7] sd: implement ->get_unique_id
  - From: Christoph Hellwig
- Re: [PATCH 2/7] sd: implement ->get_unique_id
  - From: Hannes Reinecke
- Re: [PATCH 2/7] sd: implement ->get_unique_id
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 4/5] md: Kill usage of page->index
Next by Date: Re: [PATCH 8/9] io_uring: utilize the io_batch infrastructure for more efficient polled IO
Previous by thread: Re: [PATCH 2/7] sd: implement ->get_unique_id
Next by thread: [PATCH 3/7] nfsd/blocklayout: use ->get_unique_id instead of sending SCSI commands
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]