Hi Pavel, I love your patch! Perhaps something to improve: [auto build test WARNING on v5.15-rc5] [cannot apply to axboe-block/for-next next-20211013] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 base: 64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc config: um-x86_64_defconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/9e538de87cc869bd26a3ca78da49d1437ec8688c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 git checkout 9e538de87cc869bd26a3ca78da49d1437ec8688c # save the attached .config to linux build tree make W=1 ARCH=um SUBARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): block/fops.c: In function 'block_ioctl': block/fops.c:460:37: error: implicit declaration of function 'bdev_file_inode'; did you mean 'file_inode'? [-Werror=implicit-function-declaration] 460 | struct block_device *bdev = I_BDEV(bdev_file_inode(file)); | ^~~~~~~~~~~~~~~ | file_inode >> block/fops.c:460:37: warning: passing argument 1 of 'I_BDEV' makes pointer from integer without a cast [-Wint-conversion] 460 | struct block_device *bdev = I_BDEV(bdev_file_inode(file)); | ^~~~~~~~~~~~~~~~~~~~~ | | | int In file included from block/fops.c:9: include/linux/blkdev.h:1990:57: note: expected 'struct inode *' but argument is of type 'int' 1990 | static inline struct block_device *I_BDEV(struct inode *inode) | ~~~~~~~~~~~~~~^~~~~ cc1: some warnings being treated as errors vim +/I_BDEV +460 block/fops.c cd82cca7ebfe9c Christoph Hellwig 2021-09-07 457 cd82cca7ebfe9c Christoph Hellwig 2021-09-07 458 static long block_ioctl(struct file *file, unsigned cmd, unsigned long arg) cd82cca7ebfe9c Christoph Hellwig 2021-09-07 459 { cd82cca7ebfe9c Christoph Hellwig 2021-09-07 @460 struct block_device *bdev = I_BDEV(bdev_file_inode(file)); cd82cca7ebfe9c Christoph Hellwig 2021-09-07 461 fmode_t mode = file->f_mode; cd82cca7ebfe9c Christoph Hellwig 2021-09-07 462 cd82cca7ebfe9c Christoph Hellwig 2021-09-07 463 /* cd82cca7ebfe9c Christoph Hellwig 2021-09-07 464 * O_NDELAY can be altered using fcntl(.., F_SETFL, ..), so we have cd82cca7ebfe9c Christoph Hellwig 2021-09-07 465 * to updated it before every ioctl. cd82cca7ebfe9c Christoph Hellwig 2021-09-07 466 */ cd82cca7ebfe9c Christoph Hellwig 2021-09-07 467 if (file->f_flags & O_NDELAY) cd82cca7ebfe9c Christoph Hellwig 2021-09-07 468 mode |= FMODE_NDELAY; cd82cca7ebfe9c Christoph Hellwig 2021-09-07 469 else cd82cca7ebfe9c Christoph Hellwig 2021-09-07 470 mode &= ~FMODE_NDELAY; cd82cca7ebfe9c Christoph Hellwig 2021-09-07 471 cd82cca7ebfe9c Christoph Hellwig 2021-09-07 472 return blkdev_ioctl(bdev, mode, cmd, arg); cd82cca7ebfe9c Christoph Hellwig 2021-09-07 473 } cd82cca7ebfe9c Christoph Hellwig 2021-09-07 474 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
