Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mikulas Patocka <mpatocka@xxxxxxxxxx>
Subject: Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 12 Oct 2021 08:20:49 +0200
Cc: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, Zdenek Kabelac <zkabelac@xxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx
In-reply-to: <alpine.LRH.2.02.2110040851130.30719@file01.intranet.prod.int.rdu2.redhat.com>
References: <alpine.LRH.2.02.2109231539520.27863@file01.intranet.prod.int.rdu2.redhat.com> <20210924155822.GA10064@lst.de> <alpine.LRH.2.02.2110040851130.30719@file01.intranet.prod.int.rdu2.redhat.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Mon, Oct 04, 2021 at 09:01:33AM -0400, Mikulas Patocka wrote:
> Do you want this patch?

Yes, this looks like what I want.  Minor nitpicks below:

> +	.fallocate_flags = BLKDEV_FALLOC_FL_SUPPORTED,

I'd probably call this fallocate_supported_flags.

> +	.fallocate_flags = FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE | FALLOC_FL_ZERO_RANGE,

Please avoid over 80 lines for a plain list of flags.

Follow-Ups:
- [PATCH v3] loop: don't print warnings if the underlying filesystem doesn't support discard
  - From: Mikulas Patocka

References:
- [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
  - From: Mikulas Patocka
- Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
  - From: Christoph Hellwig
- Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
  - From: Mikulas Patocka

Prev by Date: [PATCH] driver: floppy: fix warning in __alloc_pages
Next by Date: Re: [PATCH] block-map: added error handling for bio_copy_kern()
Previous by thread: Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
Next by thread: [PATCH v3] loop: don't print warnings if the underlying filesystem doesn't support discard
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]