On Tue, Oct 05, 2021 at 03:38:18AM +0000, Chaitanya Kulkarni wrote:
> On 10/4/21 19:23, Ming Lei wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > Hello Chaitanya,
> >
> > On Fri, Oct 01, 2021 at 05:56:04AM +0000, Chaitanya Kulkarni wrote:
> >> On 9/30/2021 5:56 AM, Ming Lei wrote:
> >>> External email: Use caution opening links or attachments
> >>>
> >>>
> >>> Add two APIs for stopping and starting admin queue.
> >>>
> >>> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx>
> >>
> >>
> >> this patch looks good to me, but from the feedback I've received in past
> >> we need to add the new functions in the patch where they are actually
> >> used than adding it in a separate patch.
> >
> > The added two APIs are exported via EXPORT_SYMBOL_GPL(), so it won't
> > cause any build warning. I see lots of such practise too.
> >
>
> the comment was not related to any build or warning.
>
> > It is easier for reviewing in this way since the 1st patch focuses on
> > API implementation, and the 2nd patch focuses on using the API,
> > especially there are lots of users in patch 2.
> >
>
> I am aware of that, just sharing what I got the comments in the past.
>
> > But if you really don't like this way, I am fine to merge the two since
> > merging is always easier than splitting, :-)
> >
>
> it will be good if we can keep the consistency ... nothing else ..
OK, got it, and the latest such nvme patch is the following one, which
introduced an API in one standalone patch.
commit dda3248e7fc306e0ce3612ae96bdd9a36e2ab04f
Author: Chao Leng <lengchao@xxxxxxxxxx>
Date: Thu Feb 4 08:55:11 2021 +0100
nvme: introduce a nvme_host_path_error helper
Thanks
Ming
