Re: [PATCH] null_blk: poll queue support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/14/21 3:38 PM, Pavel Begunkov wrote:
> On 4/17/21 4:29 PM, Jens Axboe wrote:
>> There's currently no way to experiment with polled IO with null_blk,
>> which seems like an oversight. This patch adds support for polled IO.
>> We keep a list of issued IOs on submit, and then process that list
>> when mq_ops->poll() is invoked.
> 
> That would be pretty useful to have.
> 
> to fold in:
> 
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index 5914fed8fa56..eb5cfe189e90 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -1508,7 +1508,7 @@ static int null_poll(struct blk_mq_hw_ctx *hctx)
>  		cmd = blk_mq_rq_to_pdu(req);
>  		cmd->error = null_process_cmd(cmd, req_op(req), blk_rq_pos(req),
>  						blk_rq_sectors(req));
> -		nullb_complete_cmd(cmd);
> +		end_cmd(cmd);
>  		nr++;
>  	}

Let's try again with that...

-- 
Jens Axboe




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux