On 2021/09/10 11:32, Xu Wang wrote: > The request_queue pointer returned from bdev_get_queue() shall > never be NULL, so the null check is unnecessary, just remove it. > > Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx> > --- > drivers/block/xen-blkback/xenbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index 33eba3df4dd9..f05132b9ddbf 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -516,7 +516,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, > vbd->type |= VDISK_REMOVABLE; > > q = bdev_get_queue(bdev); > - if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags)) > + if test_bit(QUEUE_FLAG_WC, &q->queue_flags) Missing parenthesis. Did you even compile this ? > vbd->flush_support = true; > > if (q && blk_queue_secure_erase(q)) And why not change this one too ? > -- Damien Le Moal Western Digital Research
