On 9/9/21 2:40 PM, Jens Axboe wrote: > On 9/8/21 9:46 PM, Zenghui Yu wrote: >> We use device_initialize() to take refcount for the device but forget to >> put_device() on device teardown, which ends up leaking private data of the >> driver core, dev_name(), etc. This is reported by kmemleak at boot time if >> we compile kernel with DEBUG_TEST_DRIVER_REMOVE. >> >> Note that adding the missing put_device() is _not_ sufficient to fix device >> unregistration. As we don't provide the .release() method for device, which >> turned out to be typically wrong and will be complained loudly by the >> driver core. >> >> Fix both of them. > > Applied, thanks. Actually, let's move this through the SCSI tree, as the offending patch went that way (and my branches are behind that point). -- Jens Axboe
