On 9/7/21 8:42 AM, Tetsuo Handa wrote: > On 2021/09/07 23:36, Jens Axboe wrote: >> On 9/7/21 5:52 AM, Tetsuo Handa wrote: >>> The simplest fix is to call probe function without holding >>> major_names_lock [1], but Christoph Hellwig does not like such idea. >>> Therefore, instead of holding major_names_lock in blkdev_show(), >>> introduce a different lock for blkdev_show() in order to break >>> "sb_writers#$N => &p->lock => major_names_lock" dependency chain. >> >> Agree, that's probably the easiest fix here. Applied, thanks. >> > > Sorry, can you update the patch title to: > > block: genhd: don't hold major_names_lock in blkdev_show() I already have a number of patches (and a pull) sitting on top of it... -- Jens Axboe
