On 8/30/21 7:56 PM, Linus Torvalds wrote: > On Mon, Aug 30, 2021 at 7:32 AM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> 2) drivers/block/virtio_blk.c - error handling fix later in the 5.14 >> cycle ends up touching the same out path. My resolution: >> >> - goto out_cleanup_disk; >> ++ goto err_cleanup_disk; > .. >> -out_cleanup_disk: >> +err_cleanup_disk: > > I did it the other way, and used "out_cleanup_disk" to match all the > other "out_xyz" cases in that function.. > > That should obviously be equivalent, unless something strange is going on. Yeah that's totally fine, and it's funny because that is how I did it the other times too. When sending this out, not sure why it ended up differently. I do think out_* is the right choice, matches the other ones. -- Jens Axboe
