On 8/20/21 11:20 AM, Mike Snitzer wrote: > On Fri, Aug 20 2021 at 5:49P -0400, > Christoph Hellwig <hch@xxxxxx> wrote: > >> This essentially reverts "block: remove the extra kobject reference in >> bd_link_disk_holder". That commit dropped the extra reference because >> the condition in the comment can't be true. But it turns out that >> comment did not actually describe the problematic situation, so add >> back the extra reference and document it properly. >> >> Fixes: fbd9a39542ec ("block: remove the extra kobject reference in bd_link_disk_holder") >> Reported-by: Tushar Sugandhi <tusharsu@xxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Looks good, thanks. > (btw, your linux-block cc had a typo, Jens are you able to pick this fix up regardless?) Yep, just did it manually. -- Jens Axboe