On Wed, Aug 18, 2021 at 07:22:09AM -0500, Douglas Miller wrote: > +++ b/block/sed-opal.c > @@ -75,7 +75,11 @@ struct parsed_resp { > struct opal_dev { > bool supported; > + bool locking_supported; > + bool locking_enabled; > + bool locked; > bool mbr_enabled; > + bool mbr_done; Please switch all these bools (or u8s in the user space ABI) to flags with descriptive names on an u32 variable.