On Thu, 2021-08-19 at 22:52 +0300, Denis Efremov wrote:
> Hi,
>
> Why do you want to add "if ($orig_desc =~ /^".*"$/);" here? and not just substr($orig_desc, 2, -2);?
Because commit descriptions sometimes to not have quotes like
commit <deadbeef> (Multiple word description)
btw:
I tested the last proposal with this script:
$ git log --grep="commit [0-9a-f]" -i --format=%h -1000 | \
while read commit ; do \
echo $commit; \
./scripts/checkpatch.pl --git --no-summary --quiet --types=GIT_COMMIT_ID $commit ; \
done
and there are still a fair number of ERRORs.
And I'm not sure if this particular ERROR is that useful overall.
