On 2021/08/08 1:16, Jens Axboe wrote:
> On 8/6/21 5:18 AM, Damien Le Moal wrote:
>> diff --git a/include/uapi/linux/ioprio.h b/include/uapi/linux/ioprio.h
>> index abc40965aa96..99d37d4807b8 100644
>> --- a/include/uapi/linux/ioprio.h
>> +++ b/include/uapi/linux/ioprio.h
>> @@ -31,9 +31,9 @@ enum {
>> };
>>
>> /*
>> - * 8 best effort priority levels are supported
>> + * The RT and BE priority classes both support up to 8 priority levels.
>> */
>> -#define IOPRIO_BE_NR 8
>> +#define IOPRIO_NR_LEVELS 8
>
> That might not be a good idea, if an application already uses
> IOPRIO_BE_NR...
Hmmm. include/uapi/linux/ioprio.h is being introduced with kernel 5.15. These
definition are not UAPI level right now.
What about something like this:
#define IOPRIO_NR_LEVELS 8
#define IOPRIO_BE_NR IOPRIO_NR_LEVELS
To keep IOPRIO_BE_NR ?
OR,
Keep IOPRIO_BE_NR as is in include/uapi/linux/ioprio.h and add
#define IOPRIO_NR_LEVELS IOPRIO_BE_NR
in include/linux/ioprio.h ?
Both would still allow doing some cleanup kernel side.
Or I can just drop this patch too.
--
Damien Le Moal
Western Digital Research
