Hi, Thanks for your review. Now I am not sure whether or not it is a better idea that doing synchronous or asynchronous del_gendisk() according to NBD_CFLAG_DESTROY_ON_DISCONNECT, and will wait for some feedback from Josef. Thanks, Tao On 7/28/2021 1:39 PM, Christoph Hellwig wrote: > Thanks, > > this looks good to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > .