On Tue, Jul 27 2021 at 12:18P -0400, Mike Snitzer <snitzer@xxxxxxxxxx> wrote: > On Tue, Jul 27 2021 at 12:02P -0400, > Christoph Hellwig <hch@xxxxxx> wrote: > > > On Tue, Jul 27, 2021 at 11:58:46AM -0400, Mike Snitzer wrote: > > > > This did not make a different to my testing > > > > using dmsetup and the lvm2 tools. > > > > > > I'll try these changes running through the lvm2 testsuite. > > > > Btw, is ther documentation on how to run it somewhere? I noticed > > tests, old-tests and unit-tests directories, but no obvious way > > to run them. > > I haven't tracked how it has changed in a while, but I always run: > make check_local > > (but to do that you first need to ./configure how your distro does > it... so that all targets are enabled, etc. Then: make). > > Will revisit this shortly and let you know if my process needed to > change at all due to lvm2 changes. Yeap, same process as I described above. Same 6 tests fail in the lvm2 testsuite with or without your changes, so nothing to do with your changes. I'll review your patches closer tomorrow (first pass it all looked pretty good). Mike
