Re: [PATCH 2/9] block: assert the locking state in delete_partition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/22/2021 12:53 AM, Christoph Hellwig wrote:
Add a lockdep assert instead of the outdated locking comment.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Josef Bacik <josef@xxxxxxxxxxxxxx>
Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
---
  block/partitions/core.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/block/partitions/core.c b/block/partitions/core.c
index 4230d4f71879..9902b1635b7d 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -281,12 +281,10 @@ struct device_type part_type = {
  	.uevent		= part_uevent,
  };
-/*
- * Must be called either with open_mutex held, before a disk can be opened or
- * after all disk users are gone.
- */
  static void delete_partition(struct block_device *part)
  {
+	lockdep_assert_held(&part->bd_disk->open_mutex);
+
  	fsync_bdev(part);
  	__invalidate_device(part, true);

Reviewed-by: Chaitanya Kulkarni <ckulkarnilinux@xxxxxxxxx>

--
-ck



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux