Re: [PATCH V5 2/3] blk-mq: mark if one queue map uses managed irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 21, 2021 at 07:53:22PM +0100, John Garry wrote:
> On 21/07/2021 10:17, Ming Lei wrote:
> 
> FWIW,
> 
> Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
> 
> > diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
> > index 1d18447ebebc..d54a795ec971 100644
> > --- a/include/linux/blk-mq.h
> > +++ b/include/linux/blk-mq.h
> > @@ -192,7 +192,8 @@ struct blk_mq_hw_ctx {
> >   struct blk_mq_queue_map {
> >   	unsigned int *mq_map;
> >   	unsigned int nr_queues;
> > -	unsigned int queue_offset;
> > +	unsigned int queue_offset:31;
> > +	unsigned int use_managed_irq:1;
> 
> late nit: I'd be inclined to call this "drain_hw_queue" or similar, which is
> what it means to blk-mq

But 'drain_hw_queue' isn't straightforward when it is checked in
blk_mq_alloc_request_hctx().


Thanks,
Ming




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux