I have compiled the kernel with a cross compiler "hppa-linux-gnu-" v9.3.0 on x86-64 host machine. I got the following warning: block/genhd.c: In function ‘diskstats_show’: block/genhd.c:1227:1: warning: the frame size of 1688 bytes is larger than 1280 bytes [-Wframe-larger-than=] 1227 | } by Reduced the stack footprint, using new printf specifier to print the bdevname and wrapping div_u64 function with non-inline wrapper function, the warning was not omitted anymore. Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@xxxxxxxxx> --- block/genhd.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/block/genhd.c b/block/genhd.c index 9f8cb7beaad1..6d22b84b182b 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1151,6 +1151,11 @@ const struct device_type disk_type = { }; #ifdef CONFIG_PROC_FS +static noinline u64 call_div_u64(u64 dividend, u32 divisor) +{ + return div_u64(dividend, divisor); +} + /* * aggregate disk stat collector. Uses the same stats that the sysfs * entries do, above, but makes them available through one seq_file. @@ -1162,7 +1167,6 @@ static int diskstats_show(struct seq_file *seqf, void *v) { struct gendisk *gp = v; struct block_device *hd; - char buf[BDEVNAME_SIZE]; unsigned int inflight; struct disk_stats stat; unsigned long idx; @@ -1185,40 +1189,39 @@ static int diskstats_show(struct seq_file *seqf, void *v) else inflight = part_in_flight(hd); - seq_printf(seqf, "%4d %7d %s " + seq_printf(seqf, "%4d %7d %pg " "%lu %lu %lu %u " "%lu %lu %lu %u " "%u %u %u " "%lu %lu %lu %u " "%lu %u" "\n", - MAJOR(hd->bd_dev), MINOR(hd->bd_dev), - disk_name(gp, hd->bd_partno, buf), + MAJOR(hd->bd_dev), MINOR(hd->bd_dev), gp, stat.ios[STAT_READ], stat.merges[STAT_READ], stat.sectors[STAT_READ], - (unsigned int)div_u64(stat.nsecs[STAT_READ], - NSEC_PER_MSEC), + (unsigned int)call_div_u64(stat.nsecs[STAT_READ], + NSEC_PER_MSEC), stat.ios[STAT_WRITE], stat.merges[STAT_WRITE], stat.sectors[STAT_WRITE], - (unsigned int)div_u64(stat.nsecs[STAT_WRITE], - NSEC_PER_MSEC), + (unsigned int)call_div_u64(stat.nsecs[STAT_WRITE], + NSEC_PER_MSEC), inflight, jiffies_to_msecs(stat.io_ticks), - (unsigned int)div_u64(stat.nsecs[STAT_READ] + - stat.nsecs[STAT_WRITE] + - stat.nsecs[STAT_DISCARD] + - stat.nsecs[STAT_FLUSH], - NSEC_PER_MSEC), + (unsigned int)call_div_u64(stat.nsecs[STAT_READ] + + stat.nsecs[STAT_WRITE] + + stat.nsecs[STAT_DISCARD] + + stat.nsecs[STAT_FLUSH], + NSEC_PER_MSEC), stat.ios[STAT_DISCARD], stat.merges[STAT_DISCARD], stat.sectors[STAT_DISCARD], - (unsigned int)div_u64(stat.nsecs[STAT_DISCARD], - NSEC_PER_MSEC), + (unsigned int)call_div_u64(stat.nsecs[STAT_DISCARD], + NSEC_PER_MSEC), stat.ios[STAT_FLUSH], - (unsigned int)div_u64(stat.nsecs[STAT_FLUSH], - NSEC_PER_MSEC) + (unsigned int)call_div_u64(stat.nsecs[STAT_FLUSH], + NSEC_PER_MSEC) ); } rcu_read_unlock(); -- 2.29.0.rc1.dirty