On Wed, Jun 30, 2021 at 09:57:05PM +0000, Damien Le Moal wrote: > On 2021/07/01 3:58, Sagi Grimberg wrote: > > > >>> diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h > >>> index 21140132a30d..600c5dd1a069 100644 > >>> --- a/include/linux/blk-mq.h > >>> +++ b/include/linux/blk-mq.h > >>> @@ -403,6 +403,7 @@ enum { > >>> */ > >>> BLK_MQ_F_STACKING = 1 << 2, > >>> BLK_MQ_F_TAG_HCTX_SHARED = 1 << 3, > >>> + BLK_MQ_F_NOT_USE_MANAGED_IRQ = 1 << 4, > >> > >> My 2 cents: BLK_MQ_F_NO_MANAGED_IRQ may be a better/shorter name. > > > > Maybe BLK_MQ_F_UNMANAGED_IRQ? > > Even better :) Since most drivers are unmanaged, shouldn't that be the default? The managed irq drivers should get to set a flag instead.