On Tue, Jun 22, 2021 at 08:44:19PM +0300, Anton Suvorov wrote: > Stack usage reduced (measured with allyesconfig): Not just stack footprint, but also a whole lot cleaner code in general. > - bdevname(state->bdev, b), blk); > + pr_err("Dev %pg: unable to read RDB block %d\n", state->bdev, blk); > - bdevname(state->bdev, b), blk); > + pr_err("Dev %pg: RDB in block %d has bad checksum\n", state->bdev, blk); > - pr_err("Dev %s: unable to read partition block %d\n", > - bdevname(state->bdev, b), blk); > + pr_err("Dev %pg: unable to read partition block %d\n", state->bdev, blk); [...] Please keep the non-format string arguments on separate lines instead of creating unreadable lines.