On Tue, Jun 22, 2021 at 02:06:59PM -0700, Luis Chamberlain wrote: > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -2039,31 +2039,68 @@ EXPORT_SYMBOL(dev_driver_string); > > #define to_dev_attr(_attr) container_of(_attr, struct device_attribute, attr) > > +struct bus_type *bus_get(struct bus_type *bus); > +void bus_put(struct bus_type *bus); > + Didn't checkpatch complain about this? We have a local .h file for stuff like this, can you please use it? thanks, greg k-h