On Mon, Jun 21, 2021 at 03:00:48PM -0600, Jens Axboe wrote: > On 6/21/21 2:57 PM, Veronika Kabatova wrote: > > On Mon, Jun 21, 2021 at 9:20 PM Veronika Kabatova <vkabatov@xxxxxxxxxx> wrote: > >> > >> On Mon, Jun 21, 2021 at 9:17 PM CKI Project <cki-project@xxxxxxxxxx> wrote: > >>> > >>> > >>> Hello, > >>> > >>> We ran automated tests on a recent commit from this kernel tree: > >>> > >>> Kernel repo: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git > >>> Commit: b0740de3330a - Merge branch 'for-5.14/drivers-late' into for-next > >>> > >>> The results of these automated tests are provided below. > >>> > >>> Overall result: FAILED (see details below) > >>> Merge: OK > >>> Compile: FAILED > >>> > >> > >> Hi, > >> > >> the failure is introduced between this commit and d142f908ebab64955eb48e. > >> Currently seeing if I can bisect it closer but maybe someone already has an > >> idea what went wrong. > >> > > > > First commit failing the compilation is 7a2b0ef2a3b83733d7. > > Where's the log? Adding Willy... I think the result was from 1f26b0627b461. There's an implied header inclusion order such that linux/fs.h must be included before linux/fileattr.h. The reported error for fs/orangefs/inode.c had been getting the inclusion correct by chance through: linux/bvec.h linux/mm.h linux/huge_mm.h linux/fs.h 7a2b0ef2a3b83733d7 replaced bvec.h's mm.h inclusion with mm_types.h, so now orangefs.h doesn't have the inclusion order correct anymore. But we usually don't like inlcusion order dependencies in kernel, so I think linux/fileattr.h needs to directly include the files it depends on. --- diff --git a/include/linux/fileattr.h b/include/linux/fileattr.h index 9e37e063ac69..34e153172a85 100644 --- a/include/linux/fileattr.h +++ b/include/linux/fileattr.h @@ -3,6 +3,8 @@ #ifndef _LINUX_FILEATTR_H #define _LINUX_FILEATTR_H +#include <linux/fs.h> + /* Flags shared betwen flags/xflags */ #define FS_COMMON_FL \ (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ --
