On 6/21/21 9:25 AM, Coly Li wrote: > On 6/21/21 11:14 PM, Jens Axboe wrote: >> On 6/14/21 11:49 PM, Coly Li wrote: >>> Hi Jens, >>> >>> Here are the bcache patches for Linux v5.14. >>> >>> The patches from Chao Yu and Ding Senjie are useful code cleanup. The >>> rested patches for the NVDIMM support to bcache journaling. >>> >>> For the series to support NVDIMM to bache journaling, all reported >>> issue since last merge window are all fixed. And no more issue detected >>> during our testing or by the kernel test robot. If there is any issue >>> reported during they stay in linux-next, I, Jianpang and Qiaowei will >>> response and fix immediately. >>> >>> Please take them for Linux v5.14. >> I'd really like the user api bits to have some wider review. Maybe >> I'm missing something, but there's a lot of weird stuff in the uapi >> header that includes things like pointers etc. >> > > Hi Jens, > > As I explained 2 merge windows before, we use nvdimm as non-volatiled > memory, that is, the > memory objects are stored on nvdimm as memory object which are > non-volatiled. This is why > you see the pointers in the data structure, e.g. the list is stored on > NVDIMM area, and the code > goes through the list directly on the NVDIMM, we don't load them into > memory. > > This is not block device interface. Right, and I'm not oblivious to those emails. What I'm saying is that we need more review of that, so far it seems to stand unreviewed. > I try to ask Dan Williams, Jan Kara, Christoph Hellwig and Hannes > Reineicke to help to review, > hope there are some experts may help to take a look. That'd be great. -- Jens Axboe
