On Mon, Jun 21, 2021 at 09:20:36AM +0200, Christoph Hellwig wrote: > On Thu, Jun 17, 2021 at 06:35:47PM +0800, Ming Lei wrote: > > There has been 3 users, and will be more, so add one such helper. > > > > Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> > > Reviewed-by: Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> > > Reviewed-by: Hannes Reinecke <hare@xxxxxxx> > > Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxx> > > I still don't like hiding a simple flag test like this, it just adds > another step to grepping what is going on. It is actually one pattern in block layer since there is so many such macros of blk_queue_*. And it makes the check line shorter. Thanks, Ming