On 6/9/21 12:11 AM, Johannes Thumshirn wrote: > On 09/06/2021 01:07, Bart Van Assche wrote: >> +#define SHOW_INT(__FUNC, __VAR) \ >> static ssize_t __FUNC(struct elevator_queue *e, char *page) \ >> { \ >> struct deadline_data *dd = e->elevator_data; \ >> - int __data = __VAR; \ >> - if (__CONV) \ >> - __data = jiffies_to_msecs(__data); \ >> - return deadline_var_show(__data, (page)); \ >> -} >> -SHOW_FUNCTION(deadline_read_expire_show, dd->fifo_expire[DD_READ], 1); >> -SHOW_FUNCTION(deadline_write_expire_show, dd->fifo_expire[DD_WRITE], 1); >> -SHOW_FUNCTION(deadline_writes_starved_show, dd->writes_starved, 0); >> -SHOW_FUNCTION(deadline_front_merges_show, dd->front_merges, 0); >> -SHOW_FUNCTION(deadline_fifo_batch_show, dd->fifo_batch, 0); >> -#undef SHOW_FUNCTION >> + \ >> + return sysfs_emit((page), "%d\n", __VAR); \ >> +} > > Nit: the () around page aren't needed Right, I will remove these parentheses. Thanks, Bart.