On 5/26/21 11:45 PM, Hannes Reinecke wrote: > On 5/27/21 3:01 AM, Bart Van Assche wrote: >> /* >> + * Callback function called from inside blk_mq_free_request(). >> + * >> * For zoned block devices, write unlock the target zone of >> * completed write requests. Do this while holding the zone lock >> * spinlock so that the zone is never unlocked while deadline_fifo_request() >> > Shouldn't these be kernel-doc comments? Hi Hannes, When using the kernel-doc format it is required to document the meaning of all function arguments. It seems to me that it is easy to guess what the meaning of the function arguments is in the deadline scheduler? Bart.