Re: [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bvanassche@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
Date: Thu, 27 May 2021 02:30:58 +0000
Accept-language: en-US
Cc: "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, Adam Manzanares <Adam.Manzanares@xxxxxxx>, Damien Le Moal <Damien.LeMoal@xxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>
References: <20210527010134.32448-1-bvanassche@acm.org> <20210527010134.32448-7-bvanassche@acm.org>
Wdcipoutbound: EOP-TRUE

On 5/26/21 18:02, Bart Van Assche wrote:
> -	dd->fifo_expire[DD_READ] = read_expire;
> +	dd->fifo_expire[DD_READ] = blk_queue_nonrot(q) ? read_expire_nonrot :
> +		read_expire_rot;

I've got comments about not using  ?:.

Apart from that looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>

References:
- [PATCH 0/9] Improve I/O priority support
  - From: Bart Van Assche
- [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media
  - From: Bart Van Assche

Prev by Date: Re: [PATCH 5/9] block/mq-deadline: Improve compile-time argument checking
Next by Date: Re: [PATCH 3/3] virtio_blk: implement blk_mq_ops->poll()
Previous by thread: [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media
Next by thread: Re: [PATCH 6/9] block/mq-deadline: Reduce the read expiry time for non-rotational media
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]