On Wed, May 12, 2021 at 02:55:59PM -0700, Sagi Grimberg wrote: > I think that the combination of oneshot and nosleep flags to replace > a boolen spin is a little hard to follow (especially that spin doesn't > mean spinning without sleeping). > > Maybe we should break it to: > 1. replace spin to flags with ONESHOT passed from io_uring (direct > replacement) > 2. add NOSLEEP passed from io_uring as there is no need for it. > > Just a suggestion though that would help (me at least) to follow > this more easily. I've split it up for the next version.