FWIW, that patch needs a few updates, so I will be sending out an updated version (ETA within next week is the plan), but I do agree that Ack: would be good since there were some strong philosophical objections in the beginning & it might make sense to let the wider community know those are being addressed Thanks, - Enrico On Wed, May 5, 2021 at 2:11 PM Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > On Wed, May 05, 2021 at 06:43:14AM +0100, Christoph Hellwig wrote: > > On Tue, Apr 20, 2021 at 04:25:56PM +0000, Enrico Granata wrote: > > > In the course of review, some concerns were surfaced about the > > > original virtio-blk lifetime proposal, as it depends on the eMMC > > > spec which is not open > > > > > > Add a more detailed description of the meaning of the fields > > > added by that proposal to the virtio-blk specification, as to > > > make it feasible to understand and implement the new lifetime > > > metrics feature without needing to refer to JEDEC's specification > > > > > > This patch does not change the meaning of those fields nor add > > > any new fields, but it is intended to provide an open and more > > > clear description of the meaning associated with those fields. > > > > > > Signed-off-by: Enrico Granata <egranata@xxxxxxxxxx> > > > > Still not a fan of the encoding, but at least it is properly documented > > now: > > > > Acked-by: Christoph Hellwig <hch@xxxxxx> > > With that, would you like to ack the virtip-blk patch too? > The format didn't actually change ... > > -- > MST > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@xxxxxxxxxxxxxxxxxxxx > For additional commands, e-mail: virtio-dev-help@xxxxxxxxxxxxxxxxxxxx >
