On Tue, Apr 20, 2021 at 02:35:53PM -0700, Bart Van Assche wrote: > On 4/13/21 12:50 AM, Daniel Wagner wrote: > > Maybe you could also annotate blk_mq_all_tag_iter() with a > > might_sleep(). This would help to find API abusers more easily. > > Hmm ... my understanding is that blk_mq_all_tag_iter() does not sleep > since that function does not sleep itself and since the only caller of > blk_mq_all_tag_iter() callers passes a callback function that does not > sleep? Yes, you are right. I read the documentation and assumed a might_sleep() would be missing.