Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 11/20/20 12:28, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a break statement instead of just > letting the code fall through to the next, and by adding a fallthrough > pseudo-keyword in places whre the code is intended to fall through. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > --- > drivers/block/drbd/drbd_receiver.c | 1 + > drivers/block/drbd/drbd_req.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c > index dc333dbe5232..c19bb74ac935 100644 > --- a/drivers/block/drbd/drbd_receiver.c > +++ b/drivers/block/drbd/drbd_receiver.c > @@ -5863,6 +5863,7 @@ static int got_NegRSDReply(struct drbd_connection *connection, struct packet_inf > switch (pi->cmd) { > case P_NEG_RS_DREPLY: > drbd_rs_failed_io(device, sector, size); > + break; > case P_RS_CANCEL: > break; > default: > diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c > index 330f851cb8f0..9f212a923a3c 100644 > --- a/drivers/block/drbd/drbd_req.c > +++ b/drivers/block/drbd/drbd_req.c > @@ -750,6 +750,7 @@ int __req_mod(struct drbd_request *req, enum drbd_req_event what, > > case WRITE_ACKED_BY_PEER_AND_SIS: > req->rq_state |= RQ_NET_SIS; > + fallthrough; > case WRITE_ACKED_BY_PEER: > /* Normal operation protocol C: successfully written on peer. > * During resync, even in protocol != C, >
