On 4/19/21 9:44 PM, Coly Li wrote: > In drivers/md/bcache/Kconfig, setting BCACHE_NVM_PAGES to "selected" > LIBNVDIMM and DAX is improper. This patch changes to Kconfig dependance > from "selected" to "depends on" for LIBNVDIMM and DAX. > > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Cc: Jens Axboe <axboe@xxxxxxxxx> > Signed-off-by: Coly Li <colyli@xxxxxxx> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested Thanks. > --- > drivers/md/bcache/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig > index 0996e366ad0b..59999f24d89e 100644 > --- a/drivers/md/bcache/Kconfig > +++ b/drivers/md/bcache/Kconfig > @@ -40,7 +40,7 @@ config BCACHE_NVM_PAGES > bool "NVDIMM support for bcache (EXPERIMENTAL)" > depends on BCACHE > depends on PHYS_ADDR_T_64BIT > - select LIBNVDIMM > - select DAX > + depends on LIBNVDIMM > + depends on DAX > help > nvm pages allocator for bcache. > -- ~Randy