Re: [PATCH 1/2] bcache: Kconfig dependence fix for NVDIMM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/19/21 9:44 PM, Coly Li wrote:
> In drivers/md/bcache/Kconfig, setting BCACHE_NVM_PAGES to "selected"
> LIBNVDIMM and DAX is improper. This patch changes to Kconfig dependance
> from "selected" to "depends on" for LIBNVDIMM and DAX.
> 
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Coly Li <colyli@xxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested


Thanks.

> ---
>  drivers/md/bcache/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
> index 0996e366ad0b..59999f24d89e 100644
> --- a/drivers/md/bcache/Kconfig
> +++ b/drivers/md/bcache/Kconfig
> @@ -40,7 +40,7 @@ config BCACHE_NVM_PAGES
>  	bool "NVDIMM support for bcache (EXPERIMENTAL)"
>  	depends on BCACHE
>  	depends on PHYS_ADDR_T_64BIT
> -	select LIBNVDIMM
> -	select DAX
> +	depends on LIBNVDIMM
> +	depends on DAX
>  	help
>  	nvm pages allocator for bcache.
> 


-- 
~Randy




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux