> On Apr 12, 2021, at 10:41 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> Commit b7819b925918 ("block: remove the blk_execute_rq return value")
> changed the return type of blk_execute_rq() from int into void. That
> change made a comment in sg_io() obsolete. Hence remove that comment.
>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Johannes Thumshirn <jthumshirn@xxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> block/scsi_ioctl.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index 1048b0925567..1b3fe99b83a6 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -353,10 +353,6 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk,
>
> start_time = jiffies;
>
> - /* ignore return value. All information is passed back to caller
> - * (if he doesn't check that is his problem).
> - * N.B. a non-zero SCSI status is _not_ necessarily an error.
> - */
> blk_execute_rq(bd_disk, rq, at_head);
>
> hdr->duration = jiffies_to_msecs(jiffies - start_time);
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
