On Mon, Apr 12, 2021 at 11:16:59AM +0100, Christoph Hellwig wrote:
> > +static int blk_bio_poll_io(struct io_context *submit_ioc,
> > + struct io_context *poll_ioc)
>
> Givem that poll_ioc is always current->io_context there is no
> need to pass it.
Yeah, it is true.
>
> > + struct blk_bio_poll_ctx *poll_ctx = poll_ioc ?
> > + poll_ioc->data : NULL;
>
> and it really should not be NULL here, should it?
Yeah, it is NULL just in case of memory allocation failure.
>
> > +static int __blk_bio_poll(blk_qc_t cookie)
> > +{
> > + struct io_context *poll_ioc = current->io_context;
> > + pid_t pid;
> > + struct task_struct *submit_task;
> > + int ret;
> > +
> > + pid = (pid_t)cookie;
> > +
> > + /* io poll often share io submission context */
> > + if (likely(current->pid == pid && blk_bio_ioc_valid(current)))
> > + return blk_bio_poll_io(poll_ioc, poll_ioc);
> > +
> > + submit_task = find_get_task_by_vpid(pid);
> > + if (likely(blk_bio_ioc_valid(submit_task)))
> > + ret = blk_bio_poll_io(submit_task->io_context, poll_ioc);
> > + else
> > + ret = 0;
> > + if (likely(submit_task))
> > + put_task_struct(submit_task);
>
> Wouldn't it make more sense to just store the submitting context
> in the bio, even if that uses more space? Having to call
But where to store the submitting context in bio? pid is 32bit and we can
pass it from submit_bio() perfectly, then avoid to add anything to bio.
If we save the submitting context in bio, we still have to handle task
exit related race, not see any benefit.
So far bio is ~128byte with typical setting, and people usually hate to
add more stuff into bio.
> find_get_task_by_vpid in the poll context seems rather problematic.
Why? We already handle submit context early exit.
>
> Note that this requires doing the refacoring to get rid of the separate
> blk_qc_t passed up the stack I asked for earlier, but hiding all these
> details seems like a really useful change anyway.
That is hard to do because of race between submission and completion:
1) HIPRI could be cleared because of bio splitting, so we can't do that
for this kind of bio
2) we have to make sure that the bio won't be completed when storing
cookie into this bio. BIO_END_BY_POLL is added in this patch for bio
based polling. You mean we may cover all normal blk-mq polling via
BIO_END_BY_POLL?
Thanks,
Ming
