On 4/11/21 09:30, Max Gurtovoy wrote:
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index d6c821d48090..9ca80e38f7e5 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -84,6 +84,10 @@ enum {
> NULL_Q_MQ = 2,
> };
>
> +static bool g_virt_boundary = false;
> +module_param_named(virt_boundary, g_virt_boundary, bool, 0444);
> +MODULE_PARM_DESC(virt_boundary, "Require a virtual boundary for the device. Default: False");
> +
The patch looks useful to me. But this will unconditionally enable
the virt boundry for all the devices created from configfs based on
the module param. Such enforcing will create an inflexibility when
user wants to create different devices for testing with different
configuration (e.g. virt bouncry on/off) with single modprobe.
