> On Apr 9, 2021, at 10:04 AM, Christoph Hellwig <hch@xxxxxx> wrote:
>
> blk_rq_append_bio is also used for the copy case, not just the map case,
> so tis debug check is not correct.
>
Small nit.. “this” spelled incorrectly above
> Fixes: 393bb12e0058 ("block: stop calling blk_queue_bounce for passthrough requests")
> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> block/blk-map.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/blk-map.c b/block/blk-map.c
> index dac78376acc899..3743158ddaeb76 100644
> --- a/block/blk-map.c
> +++ b/block/blk-map.c
> @@ -485,9 +485,6 @@ int blk_rq_append_bio(struct request *rq, struct bio *bio)
> struct bio_vec bv;
> unsigned int nr_segs = 0;
>
> - if (WARN_ON_ONCE(rq->q->limits.bounce != BLK_BOUNCE_NONE))
> - return -EINVAL;
> -
> bio_for_each_bvec(bv, bio, iter)
> nr_segs++;
>
> --
> 2.30.1
>
Looks good otherwise.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani Oracle Linux Engineering
