Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 08, 2021 at 10:01:23AM +0200, Jiri Kosina wrote:
> On Thu, 8 Apr 2021, Greg KH wrote:
> 
> > Removing a module from a system has always been "let's try it and see!"
> > type of operation for a very long time.  
> 
> Which part of it?
> 
> If there is a driver/subsystem code that can't handle the reverse 
> operation to modprobe, it clearly can't handle error handling during 
> modprobe (which, one would hope, is supported), and should be fixed.

Huh?  No, that's not the issue here, it's the issue of different
userspace code paths into the module at the same time that it is trying
to be unloaded.  That has nothing to do with loading the module the
first time as userspace is not touching those apis yet.

> If there is a particular issue in kernel dynamic linker that causes crash 
> on module removal, we'd better off fixing it. Is there one such that makes 
> you claim module removal unsupported?

The linker has nothing to do with this, it's userspace tasks touching
code paths.

thanks,

greg k-h



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux