On 3/30/21 00:39, Gioh Kim wrote: > From: Guoqing Jiang <guoqing.jiang@xxxxxxx> > > It makes more sense to add gendisk in rnbd_clt_setup_gen_disk, instead > of do it in rnbd_clt_map_device. > > Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxx> > Reviewed-by: Danil Kipnis <danil.kipnis@xxxxxxxxxxxxxxx> > Signed-off-by: Gioh Kim <gi-oh.kim@xxxxxxxxxxxxxxx> > Signed-off-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx> The add disk call seems to be out of the lock, I hope that will not result in any issues since this patch moves add_disk call when dev->lock is held. Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
