Re: [PATCH] blk-mq: Fix races between iterating over requests and freeing requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/23/21 9:26 AM, John Garry wrote:
> The first patch in my series solves the issues reported by community also:
> https://lore.kernel.org/linux-block/1614957294-188540-2-git-send-email-john.garry@xxxxxxxxxx/
> 
> And that patch should give no throughput performance hit.
> 
> The other two patches in that series are to solve more theoretical
> issues of iterator interactions, but their approach is unacceptable.
> 
> Obviously your call. IMHO, Bart's solution would make more sense.

Hi John,

In case this would not be clear, I really appreciate your work and the
time you have spent on analyzing this issue and preparing a solution.
Personally I prefer the solution to clear request pointers immediately
after these have been freed since that approach results in simpler code
and (hopefully) in code that will be easier to maintain.

Bart.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux