On Fri, Mar 19, 2021 at 01:38:13PM -0400, Mike Snitzer wrote: > On Thu, Mar 18 2021 at 12:48pm -0400, > Ming Lei <ming.lei@xxxxxxxxxx> wrote: > > > Add one req flag REQ_TAG which will be used in the following patch for > > supporting bio based IO polling. > > "REQ_TAG" is so generic yet is used in such a specific way (to mark an > FS bio as having polling context) > > I don't have a great suggestion for a better name, just seems "REQ_TAG" > is lacking... (especially given the potential for confusion due to > blk-mq's notion of "tag"). > > REQ_FS? REQ_FS_CTX? REQ_POLL? REQ_POLL_CTX? REQ_NAMING_IS_HARD :) > Maybe REQ_POLL_CTX is better, it is just for marking bios: 1) which need to be polled in this context 2) which can be polled in this context -- Ming