On 3/19/21 2:07 PM, Bhaskar Chowdhury wrote: > On 13:03 Fri 19 Mar 2021, Randy Dunlap wrote: >> >> Hm, needs some spacing fixes IMO. See below. >> >> >> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote: >> >>> >>> s/funtion/functions/ >>> >>> Plus the sentence reconstructed for better readability. >>> >>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx> >>> --- >>> Changes from V1: >>> Randy's suggestions incorporated. >>> >>> block/blk-mq-tag.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c >>> index 9c92053e704d..c2bef283db63 100644 >>> --- a/block/blk-mq-tag.c >>> +++ b/block/blk-mq-tag.c >>> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq, >>> } >>> >>> /** >>> - * blk_mq_tagset_wait_completed_request - wait until all completed req's >>> - * complete funtion is run >>> + * blk_mq_tagset_wait_completed_request - wait until all the req's >> >> the req's >> >>> + * functions completed their run >> >> and more indentation + wording on that line above: >> * functions have completed their run >> > Apology...my bad ...fixing ...V3 ...in quick time ... Easy, let's get this right instead of spinning tons of versions of a trivial patch. The text should be: Wait until all scheduled request completions have finished. If we're fixing a typo, let's actually make it understandable too... -- Jens Axboe