On Thu, Mar 18, 2021 at 01:54:53PM +0100, Christoph Hellwig wrote:
> On Thu, Mar 18, 2021 at 11:20:25AM +0000, Matthew Wilcox wrote:
> > On Thu, Mar 18, 2021 at 07:39:19AM +0100, Christoph Hellwig wrote:
> > > @@ -2875,7 +2859,6 @@ static void asc_prt_asc_board_eeprom(struct seq_file *m, struct Scsi_Host *shost
> > > uchar serialstr[13];
> > > #ifdef CONFIG_ISA
> > > ASC_DVC_VAR *asc_dvc_varp;
> > > - int isa_dma_speed[] = { 10, 8, 7, 6, 5, 4, 3, 2 };
> > >
> > > asc_dvc_varp = &boardp->dvc_var.asc_dvc_var;
> > > #endif /* CONFIG_ISA */
> >
> > I think you can remove the conditional definition & assignment of
> > asc_dvc_varp here.
>
> The way I read the driver CONFIG_ISA also covers Vesa Local Bus
> support, which is not removed by this patch. Corret me if I'm wrong.
I agree that VLB is also enabled by CONFIG_ISA in this driver,
but in this specific function, I think you removed the only use
of asc_dvc_varp.
